Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default logging in appsettings. #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lizard-boy
Copy link

@lizard-boy lizard-boy commented Oct 19, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

sso was missing the default logging configs in the prod appsettings.json

Code changes

  • appsettings.Production.json - added logging block so it's following the same standard as the other services.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Greptile Summary

Added logging configuration to the SSO service's production settings, aligning it with other services' logging standards.

  • Added Logging block in /bitwarden_license/src/Sso/appsettings.Production.json with general and console logging settings
  • Configured different log levels for various components (e.g., "Default", "Microsoft", "Microsoft.Hosting.Lifetime")
  • Potential issue: Some log levels may need adjustment for optimal production performance

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

"Logging": {
"IncludeScopes": false,
"LogLevel": {
"Default": "Debug",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Default log level set to 'Debug' in production environment may generate excessive logs and impact performance.

"Microsoft": "Information"
},
"Console": {
"IncludeScopes": true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: IncludeScopes set to true for console, but false for general logging. Ensure this is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants