Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added groupings for Auth dependencies #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lizard-boy
Copy link

@lizard-boy lizard-boy commented Oct 19, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Group dependent dependencies for Auth team.

Code changes

  • renovate.json: Added groups for dependent packages.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Greptile Summary

This pull request updates the renovate.json configuration to improve dependency management for the Auth team by grouping specific packages.

  • Added grouping for AspNetCoreRateLimit packages in .github/renovate.json
  • Added grouping for Microsoft.Azure.Cosmos packages in .github/renovate.json
  • Both new groups are excluded from the dotnet monorepo preset
  • Changes aim to streamline dependency updates for the Auth team

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

{
"matchPackagePatterns": ["^AspNetCoreRateLimit"],
"groupName": "AspNetCoreRateLimit",
"description": "Group AspNetCoreRateLimit to exclude them from the dotnet monorepo preset"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding a 'commitMessagePrefix' for consistency with other groups.

{
"matchPackagePatterns": ["^Microsoft.Azure.Cosmos"],
"groupName": "Microsoft.Azure.Cosmos",
"description": "Group Microsoft.Azure.Cosmos to exclude them from the dotnet monorepo preset"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding a 'commitMessagePrefix' for consistency with other groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants