[PM-13730] Return Policy object instead of NotFoundException #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+65
to
+67
| var policy = new AdminConsoleEntities.Policy(); | ||
| policy.Type = (PolicyType)type; | ||
| policy.Enabled = false; |
There was a problem hiding this comment.
style: Consider initializing the policy object with more meaningful default values, such as setting the OrganizationId.
Comment on lines
69
to
72
| if (!await _currentContext.ManagePolicies(orgIdGuid)) | ||
| { | ||
| throw new NotFoundException(); | ||
| return new PolicyResponseModel(policy); | ||
| } |
There was a problem hiding this comment.
logic: Returning a default policy when the user doesn't have permission might mask authorization issues. Consider if a different response would be more appropriate for this case.
Comment on lines
+73
to
77
| policy = await _policyRepository.GetByOrganizationIdTypeAsync(orgIdGuid, (PolicyType)type); | ||
| if (policy == null) | ||
| { | ||
| throw new NotFoundException(); | ||
| return new PolicyResponseModel(policy); | ||
| } |
There was a problem hiding this comment.
logic: The default policy is overwritten here if found. Ensure this doesn't cause unexpected behavior if partial data is returned from the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13730
📔 Objective
This PR removes the thrown
NotFoundExceptionwhen policies are not found and returns a defaultPolicyobject with the sameTypesent in the request and theEnabledvalue set tofalse⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changesGreptile Summary
This PR modifies the
PoliciesControllerto return a defaultPolicyobject instead of throwing aNotFoundExceptionwhen a policy is not found or when the user lacks permission to manage policies.Getmethod insrc/Api/AdminConsole/Controllers/PoliciesController.csto return a defaultPolicyobject withEnabledset tofalseNotFoundExceptionthrow when user doesn't have permission to manage policiesNotFoundExceptionfor error handling