[PM-11406] Account Management: Prevent a verified user from deleting their account #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Deprovisioning is enabled
- Added CannotDeleteManagedAccountViewModel class to handle emails related to preventing deletion of accounts managed by an organization. - Added HTML and text email templates for sending notifications about the inability to delete an account owned by an organization. - Updated IMailService interface with a new method to send the cannot delete managed account email. - Implemented the SendCannotDeleteManagedAccountEmailAsync method in HandlebarsMailService. - Added a check in UserService to send the cannot delete managed account email if the user is managed by any organization. - Added a no-op implementation for SendCannotDeleteManagedAccountEmailAsync in NoopMailService.
…-email-address' into ac/pm-11406/prevent-a-verified-user-from-deleting-their-account
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
9 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -18,6 +18,7 @@ Task SendTrialInitiationSignupEmailAsync( | |||
| ProductTierType productTier, | |||
| IEnumerable<ProductType> products); | |||
| Task SendVerifyDeleteEmailAsync(string email, Guid userId, string token); | |||
| Task SendCannotDeleteManagedAccountEmailAsync(string email); | |||
There was a problem hiding this comment.
style: consider adding XML documentation for this new method
Comment on lines
+97
to
+100
| public Task SendCannotDeleteManagedAccountEmailAsync(string email) | ||
| { | ||
| return Task.FromResult(0); | ||
| } |
There was a problem hiding this comment.
style: Consider adding XML documentation for this new method to maintain consistency with other methods in the class.
Comment on lines
+543
to
+544
| _featureService.IsEnabled(FeatureFlagKeys.AccountDeprovisioning).Returns(true); | ||
| _userService.IsManagedByAnyOrganizationAsync(user.Id).Returns(true); |
There was a problem hiding this comment.
style: Consider using a constant or enum for the feature flag key instead of a string literal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11406
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changesGreptile Summary
This pull request implements changes to prevent verified users managed by an organization from deleting their accounts and updates the email notification system accordingly.
AccountsController.Deleteto block account deletion for organization-managed usersCannotDeleteManagedAccountViewModeland corresponding HTML/text email templatesSendCannotDeleteManagedAccountEmailAsyncmethod toIMailServiceand its implementationsUserService.SendDeleteConfirmationAsyncto handle managed user scenariosAccountsControllerTeststo verify deletion prevention logic