[PM-13836] Refactor IPolicyService to remove unnecessary IOrganizationService dependency #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐๏ธ Tracking
https://bitwarden.atlassian.net/browse/PM-13836
๐ Objective
IOrganizationService
is now unused inIPolicyService.SaveAsync
so we need to remove that parameter and update any affected places such as unit tests.โฐ Reminders before review
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changesGreptile Summary
This pull request removes the
IOrganizationService
dependency from theIPolicyService
interface and its implementations, simplifying the policy management process.IOrganizationService
parameter fromIPolicyService.SaveAsync
method in/src/Core/AdminConsole/Services/IPolicyService.cs
PolicyService
implementation in/src/Core/AdminConsole/Services/Implementations/PolicyService.cs
to reflect the interface changePoliciesController
in both/src/Api/AdminConsole/Controllers/PoliciesController.cs
and/src/Api/AdminConsole/Public/Controllers/PoliciesController.cs
to removeIOrganizationService
usageSsoConfigService
in/src/Core/Auth/Services/Implementations/SsoConfigService.cs
to call_policyService.SaveAsync
without_organizationService
parameter/test/Core.Test/AdminConsole/Services/PolicyServiceTests.cs
and/test/Core.Test/Auth/Services/SsoConfigServiceTests.cs
to align with the new interface