Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13836] Refactor IPolicyService to remove unnecessary IOrganizationService dependency #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lizard-boy
Copy link

@lizard-boy lizard-boy commented Oct 19, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13836

๐Ÿ“” Objective

IOrganizationService is now unused in IPolicyService.SaveAsync so we need to remove that parameter and update any affected places such as unit tests.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Greptile Summary

This pull request removes the IOrganizationService dependency from the IPolicyService interface and its implementations, simplifying the policy management process.

  • Removed IOrganizationService parameter from IPolicyService.SaveAsync method in /src/Core/AdminConsole/Services/IPolicyService.cs
  • Updated PolicyService implementation in /src/Core/AdminConsole/Services/Implementations/PolicyService.cs to reflect the interface change
  • Modified PoliciesController in both /src/Api/AdminConsole/Controllers/PoliciesController.cs and /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs to remove IOrganizationService usage
  • Updated SsoConfigService in /src/Core/Auth/Services/Implementations/SsoConfigService.cs to call _policyService.SaveAsync without _organizationService parameter
  • Adjusted unit tests in /test/Core.Test/AdminConsole/Services/PolicyServiceTests.cs and /test/Core.Test/Auth/Services/SsoConfigServiceTests.cs to align with the new interface

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

7 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants