Resolve Billing and Secrets Manager Code (bitwarden#4645)

* Resolve Billing Warnings

* Resolve SM Warnings

bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/ProjectRepository.cs

@@ -16,7 +16,7 @@ public ProjectRepository(IServiceScopeFactory serviceScopeFactory, IMapper mappe
         : base(serviceScopeFactory, mapper, db => db.Project)
     { }
 
-    public override async Task<Core.SecretsManager.Entities.Project> GetByIdAsync(Guid id)
+    public override async Task<Core.SecretsManager.Entities.Project?> GetByIdAsync(Guid id)
     {
         using (var scope = ServiceScopeFactory.CreateScope())
         {

bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/SecretRepository.cs

@@ -19,7 +19,7 @@ public SecretRepository(IServiceScopeFactory serviceScopeFactory, IMapper mapper
         : base(serviceScopeFactory, mapper, db => db.Secret)
     { }
 
-    public override async Task<Core.SecretsManager.Entities.Secret> GetByIdAsync(Guid id)
+    public override async Task<Core.SecretsManager.Entities.Secret?> GetByIdAsync(Guid id)
     {
         using (var scope = ServiceScopeFactory.CreateScope())
         {

bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/ServiceAccountRepository.cs

@@ -263,7 +263,7 @@ from ap in grouping.DefaultIfEmpty()
         where ap.GrantedSecret.DeletedDate == null &&
               ap.GrantedSecretId != null
         select new ServiceAccountSecretsAccess(sa,
-            new List<Guid> { ap.GrantedSecretId.Value });
+            new List<Guid> { ap.GrantedSecretId!.Value });
 
     private static List<ServiceAccountSecretsAccess> FilterDirectSecretAccessResults(
         List<ServiceAccountSecretsAccess> projectSecretsAccessResults,

src/Api/Billing/Public/Controllers/OrganizationController.cs

@@ -19,17 +19,20 @@ public class OrganizationController : Controller
     private readonly ICurrentContext _currentContext;
     private readonly IOrganizationRepository _organizationRepository;
     private readonly IUpdateSecretsManagerSubscriptionCommand _updateSecretsManagerSubscriptionCommand;
+    private readonly ILogger<OrganizationController> _logger;
 
     public OrganizationController(
         IOrganizationService organizationService,
         ICurrentContext currentContext,
         IOrganizationRepository organizationRepository,
-        IUpdateSecretsManagerSubscriptionCommand updateSecretsManagerSubscriptionCommand)
+        IUpdateSecretsManagerSubscriptionCommand updateSecretsManagerSubscriptionCommand,
+        ILogger<OrganizationController> logger)
     {
         _organizationService = organizationService;
         _currentContext = currentContext;
         _organizationRepository = organizationRepository;
         _updateSecretsManagerSubscriptionCommand = updateSecretsManagerSubscriptionCommand;
+        _logger = logger;
     }
 
     /// <summary>
@@ -58,6 +61,7 @@ public async Task<IActionResult> PostSubscriptionAsync([FromBody] OrganizationSu
         }
         catch (Exception ex)
         {
+            _logger.LogError(ex, "Unhandled error while updating the subscription");
             return StatusCode(500, new { Message = "An error occurred while updating the subscription." });
         }
     }

src/Core/Billing/Services/IProviderBillingService.cs

@@ -17,7 +17,7 @@ public interface IProviderBillingService
     /// <see cref="PlanType"/>.
     /// </summary>
     /// <param name="provider">The <see cref="Provider"/> that manages the client <paramref name="organization"/>.</param>
-    /// <param name="organization">The client <see cref="Organization"/> whose <see cref="seats"/> you want to update.</param>
+    /// <param name="organization">The client <see cref="Organization"/> whose <paramref name="seats"/> you want to update.</param>
     /// <param name="seats">The number of seats to assign to the client organization.</param>
     Task AssignSeatsToClientOrganization(
         Provider provider,

src/Core/Billing/Services/ISubscriberService.cs

@@ -90,7 +90,7 @@ Task<Subscription> GetSubscriptionOrThrow(
         SubscriptionGetOptions subscriptionGetOptions = null);
 
     /// <summary>
-    /// Retrieves the <see cref="subscriber"/>'s tax information using their Stripe <see cref="Stripe.Customer"/>'s <see cref="Stripe.Customer.Address"/>.
+    /// Retrieves the <paramref name="subscriber"/>'s tax information using their Stripe <see cref="Stripe.Customer"/>'s <see cref="Stripe.Customer.Address"/>.
     /// </summary>
     /// <param name="subscriber">The subscriber to retrieve the tax information for.</param>
     /// <returns>A <see cref="TaxInformation"/> representing the <paramref name="subscriber"/>'s tax information.</returns>