Sync with Pro #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizard-boy
commented
Oct 4, 2024
lizard-boy
commented
…etary#2339) Error in [logs](https://github.com/semgrep/semgrep-proprietary/actions/runs/11061470331/job/30734143194#step:4:129) Test plan: CI synced from Pro 6ec5e0f7832e85e8c2f6a6a178de494fee102895
For non-SMS scans, it can be quite hard to find the trace. This PR logs the trace id in debug log. This only solves the problem when `--debug` is passed as well as `--trace`, so for the future we should output it as part of the results json or the error on a crash. However, it's better than the previous state. Test plan: In an arbitrary folder, run ``` (python-virtualenv) ➜ misc semgrep --config p/default . --trace --pro --debug ┌──── ○○○ ────┐ │ Semgrep CLI │ └─────────────┘ semgrep version 1.90.0 ... [00.06][DEBUG](default): !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! [00.06][INFO]: Executed as: /Users/emma/workspace/semgrep-proprietary/OSS/cli/src/semgrep/bin/semgrep-core-proprietary -json -rules /var/folders/4h/r6m5kls56r98069rz7w7f2400000gp/T/tmp379zh00m.json -j 1 -targets /var/folders/4h/r6m5kls56r98069rz7w7f2400000gp/T/tmp6sce110s -timeout 5 -timeout_threshold 3 -max_memory 0 -fast -trace -deep_inter_file -timeout_for_interfile_analysis 0 . -debug [00.06][INFO]: Version: 1.90.0 [00.06][INFO]: Tracing is enabled for this scan. The trace id is <53914f7e3a7612f09483a98c320a8f98>. ``` Also run it without `--pro`. synced from Pro 7a7dba2f40afef0123d56915efca502917536f7d
…prietary#2344) Fixing [logs](https://github.com/semgrep/semgrep-proprietary/actions/runs/11078022721/job/30784508699). Looks like this doesn't work for our 4.x ocaml environment. Good luck guys! synced from Pro 2ea8d06dfac60d2c0fd582450f6ba62bad0beb54
…oprietary#2347) test plan: make test synced from Pro 8158ec5766fac26ca5c450e3ecac452ce56801c8
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors and enhances the taint analysis functionality in Semgrep, focusing on preparing the codebase for handling higher-order functions and improving overall robustness. Key changes include:
- Improved UUID generation for better randomness and security in
Unit_LS.ml,Lsp_.ml, andSemgrep_login.ml - Updated
Gitlab_output.mlto address deprecation warnings related to Uuidm usage - Significant refactoring in
Dataflow_tainting.mlto improve taint propagation and type checking - Enhanced taint tracking and shape handling in
Shape_and_sig.mlandTaint_shape.ml - Introduction of new types and refactoring in
Sig_inst.mlandSig_inst.mlifor better handling of call effects - Added
filterfunction toTaint_setmodule inTaint.mlifor improved taint set manipulation
10 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -103,7 +103,7 @@ let mock_run_results (files : string list) : Core_runner.result = | |||
|
|
|||
| let mock_workspace ?(git = false) () : Fpath.t = | |||
| let rand_dir () = | |||
| let uuid = Uuidm.v `V4 in | |||
| let uuid = Uuidm.v4_gen (Stdlib.Random.State.make_self_init ()) () in | |||
There was a problem hiding this comment.
style: Consider using Uuidm.v4 () instead of Uuidm.v4_gen (Stdlib.Random.State.make_self_init ()) () for simplicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.