Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code relating to decision_policy and forecast_policy. #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lizard-boy
Copy link

We'll need to ship a yelpsoa-configs change that stops setting forecast_policy before we ship this.

@lizard-boy
Copy link
Author

@greptileai

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Based on the provided information, here's a summary of the key changes in this pull request:

  1. Removal of 'forecast_policy' and 'decision_policy': These options have been removed from the autoscaling configuration across the codebase, including documentation, code, and tests.

  2. Deletion of forecasting functionality: The 'paasta_tools/autoscaling/forecasting.py' file and its corresponding test file have been completely removed, indicating a significant change in the autoscaling approach.

  3. Documentation updates: The autoscaling documentation has been updated to reflect the removal of these policies and provide more detailed information about metrics providers and decision policies.

  4. Schema changes: The autoscaling schema has been modified to remove the 'forecast_policy' property, which will impact how autoscaling is configured.

  5. Code robustness: The code has been updated to handle the absence of 'decision_policy' more gracefully, preventing potential KeyError exceptions.

It's important to note that a yelpsoa-configs change to stop setting 'forecast_policy' needs to be shipped before this PR to ensure compatibility with existing configurations.

11 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants