chore: Added support for reading quey from a file #6
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds support for reading NRQL queries from files or through shell redirection in the newrelic nrql query command, enhancing its flexibility and usability.
- Added file reading capability in
internal/nrql/command_query.gofor the--queryflag - Implemented check to distinguish between file paths and direct query strings
- Enabled support for shell redirection (e.g.,
<(cat some.nrql)) and direct file paths - Minor import reordering in
internal/install/recipe_installer.goandinternal/install/recipes/process_evaluator.go
3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings
| "context" | ||
| "errors" | ||
| "fmt" | ||
| "github.com/fatih/color" | ||
| "os" | ||
| "regexp" | ||
| "strconv" | ||
| "time" | ||
|
|
||
| "github.com/fatih/color" | ||
|
|
There was a problem hiding this comment.
style: The import order has been changed, moving the standard library imports to the top and separating them from third-party imports with a blank line. This improves readability and follows Go best practices.
| "os" | ||
| "regexp" | ||
| "strconv" | ||
| "time" | ||
|
|
||
| "github.com/fatih/color" |
There was a problem hiding this comment.
style: An extra blank line has been added after the third-party imports. This is consistent with Go style guidelines and improves readability.
| _, err := os.Stat(query) | ||
| if err != nil && !errors.Is(err, os.ErrNotExist) { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
style: Consider using os.IsNotExist(err) instead of !errors.Is(err, os.ErrNotExist) for better readability and consistency with Go's standard library
| if readErr != nil { | ||
| log.Fatal(readErr) | ||
| } | ||
| query = string(fileBytes) |
There was a problem hiding this comment.
style: Consider trimming whitespace from the query string to avoid potential issues with leading/trailing spaces
Prior to this change, trying to do the following will result in an error:
$ newrelic nrql query --query <(cat some.nrql)With this change, we support proper shell redirection. And, technically, the following will also work: