-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filter-pill): DLT-1962 design #9
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR introduces a new Filter Pill component to the Dialtone design system. Here are the key points about the changes:
- Added new Filter Pill component documentation in
filter-pill.md
- Filter Pill appears to be a specialized version of the Chip component for filtering purposes
- Updated Button component documentation in
button.md
to use Vue components for disabled button examples - Added tooltip functionality to disabled buttons in the Button documentation
The Filter Pill component offers various states and configurations, including:
- Unselected and selected states
- Disabled state
- Options with and without clear buttons
- Different sizes
The documentation demonstrates how Filter Pills can be used in combination with other components like tab groups and tables for filtering various types of data (e.g., calls, CSAT, moments).
These changes enhance the Dialtone design system by providing a specific component for filtering functionality, which should improve consistency and usability across applications using the system.
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
</template> | ||
<template #content> | ||
<div class="d-ta-center d-px32 d-py64 d-fc-tertiary d-body--sm"> | ||
Popover or maybe Dropdown asdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Inconsistent placeholder text. Remove 'asdf'
<script setup> | ||
const items = [ | ||
{ name: 'All Calls and Dialpad Meetings', id: 1 }, | ||
{ name: 'External only', id: 2 }, | ||
{ name: 'Internal only', id: 3 }, | ||
]; | ||
</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider moving script to separate file for better organization
🚧 Filter Pill Design
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
📖 Description
💡 Context
📝 Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.sh
script. Read docs here: Dialtone Vue Sync ScriptFor all CSS changes:
If new component:
packages/dialtone-vue2
orpackages/dialtone-vue3
).packages/dialtone-css
package.apps/dialtone-documentation
.common/components_list.js
🔮 Next Steps
📷 Screenshots / GIFs
🔗 Sources