chore: DLT-1941 add dialtone combinator package #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julio Ortega <[email protected]>
…ialpad#500) Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
…ialpad#500) Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
…add_dt-combinator_package # Conflicts: # pnpm-lock.yaml
Signed-off-by: Julio Ortega <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces the Dialtone Combinator package to the monorepo, focusing on integration and preparation for future development.
- Added
packages/combinatorto.markdownlintignoreand.stylelintignoreto exclude it from linting - Simplified
ComponentCombinator.vue, now usingdtc-combinatorfor rendering - Updated
apps/dialtone-documentation/docs/.vuepress/config.jsto accommodate Combinator integration - Modified
apps/dialtone-documentation/docs/.vuepress/theme/client.jsto include Combinator CSS and register components - Added '@dialpad/dialtone-combinator' as a workspace dependency in
apps/dialtone-documentation/package.json
12 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+6
to
+10
| 'pnpm exec stylelint --fix --allow-empty-input', | ||
| ], | ||
| '*.{md, mdx}': [ | ||
| 'pnpm exec markdownlint' | ||
| ] | ||
| 'pnpm exec markdownlint', | ||
| ], |
There was a problem hiding this comment.
style: Consider using a consistent style for trailing commas in the configuration object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NO-MERGE] Add Dialtone Combinator package to monorepo
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will not increment the version number, but will still deploy to documentation site on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-1941
📖 Description
.markdownlintignoreand.stylelintignore💡 Context
Starting the investigation to make the dialtone-combinator work on our documentation site.
📝 Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.shscript. Read docs here: Dialtone Vue Sync ScriptFor all CSS changes:
If new component:
packages/dialtone-vue2orpackages/dialtone-vue3).packages/dialtone-csspackage.apps/dialtone-documentation.common/components_list.js🔮 Next Steps