-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DLT-1548 fix opacity classes selectors #6
base: staging
Are you sure you want to change the base?
Conversation
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
Signed-off-by: Julio Ortega <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR focuses on improving the handling of semantic colors and opacity in the Dialtone CSS framework. Here are the key changes:
- Updated HSL color extraction process to fix issues with HSLA colors always having 100% opacity
- Added individual HSL color variables with an '-a' suffix for alpha channel control
- Removed outdated dark theme implementation references (d:d-* prefix)
- Migrated from 'tinycolor2' to 'colorjs.io' for color manipulation
- Updated font color documentation with current color information
- Replaced deprecated 'd-fc-error' class with 'd-fc-critical' in various components
These changes improve the flexibility and consistency of color handling throughout the Dialtone design system, particularly for opacity adjustments and semantic color usage.
18 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR continues to improve the handling of semantic colors and opacity in the Dialtone CSS framework. Here are the key updates since the last review:
- Simplified the UtilityClassTable component by removing unnecessary class attributes and inline styles
- Updated the 'fontColorVars' section in type.json to use semantic color tokens instead of specific color values
- Removed dark mode-specific classes and references from various documentation files
- Added 'ai' to the BORDER_COLORS array in constants.cjs for AI-related border color utility classes
- Improved color processing in helpers.cjs with a new function to remove prefixes from color names
These changes further enhance the consistency and flexibility of the color system in Dialtone, while also improving documentation and removing outdated references.
18 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
"dependsOn": [ | ||
"dialtone-tokens:build" | ||
], | ||
"dependsOn": ["dialtone-tokens:build"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Dependency array formatting changed, but functionality remains the same
Fix: :hover, :focus, :focus-visible selectors on semantic colors
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-1548
📖 Description
--dt-color-${name}-a
to generated individual HSL color variablesd-fc-error
->d-fc-critical
d:d-*
prefix which was related to some old dark-theme implementation that no longer works.💡 Context
📝 Checklist
For all PRs:
For all CSS changes:
🔮 Next Steps
d-fc-error
->d-fc-critical
on Dialpad and Dialpad meetings🔗 Sources
https://colorjs.io/