fix(emoji-picker): NO-JIRA refactor fix ref reactivity in vue2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the emoji picker component in Vue 2 to address reactivity issues encountered in the product environment, specifically related to DP-113081.
- Introduced new
tabLabelsRefsdata property to store references to tab labels - Updated
setupTabLabelRefsmethod to usetabLabelsRefsfor improved reactivity - Modified
scrollToTabmethod to access tab elements usingtabLabelsRefs - Changes aim to resolve reactivity problems in Vue 2.6.14 environment
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
258
to
262
| this.tabSetLabels?.forEach((_, index) => { | ||
| const refKey = `tabLabelRef-${index}`; | ||
| if (this.$refs[refKey]) { | ||
| this.$set(this.tabLabels, index, { ...this.tabLabels[index], ref: this.$refs[refKey] }); | ||
| this.$set(this.tabLabelsRefs, index, { ref: this.$refs[refKey] }); | ||
| } |
There was a problem hiding this comment.
logic: This approach may still have reactivity issues. Consider using Vue.set() or this.$set() to ensure reactivity
| @@ -329,8 +330,7 @@ export default { | |||
| scrollToTab: function (tabIndex, focusFirstEmoji) { | |||
| const vm = this; | |||
| if (focusFirstEmoji === undefined) { focusFirstEmoji = true; } | |||
| const tabLabel = vm.tabLabels[tabIndex - 1]; | |||
| const tabElement = tabLabel.ref[0]; | |||
| const tabElement = vm.tabLabelsRefs[tabIndex - 1].ref[0]; | |||
There was a problem hiding this comment.
logic: Ensure tabIndex - 1 is always >= 0 to prevent accessing undefined array elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor fix ref reactivity in vue2
This is a refactor of this fix dialpad#512
The previous fix does not work as expected in product DP-113081, probably because the vue version (
2.6.14).This is not something new, I deal previously with this kind of issues.
This PR is just a refactor of the same fix, Im just doing it in a different way and this one seems to work.