Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PID while waiting for ADC. #4

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgerstgrasser
Copy link

Update PID calculations while waiting for ADC:

  • Move PID update code into separate doPID() method.
  • Call doPID() also from within checkStatus() delay loop.

This seems to make the PID more stable with a large D-term.

Update PID calculations while waiting for ADC:

* Move PID update code into separate doPID() method.
* Call doPID() also from within checkStatus() delay loop.
Copy link

@renatoa renatoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are at PID changes, maybe a deeper discussion is needed.
For example, there are some well established practices, validated over time by experience, that in the first minute the power level should be constant and not bigger than whatever level.
I use on my machine for example the 36% level, which is the stable power when preheating at 190 C.
A roasting approach based on profile following driven by a wild varying temperature, in the first minute, can led often to 100% level of power, which is everything you want but not a good thing...
So I suggest limiting the heater power level after charge to whatever value, with a default value lower than 50%, for safety.

@mgerstgrasser
Copy link
Author

If we are at PID changes, maybe a deeper discussion is needed.

That is a good point. But we should still fix bugs in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants