-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve container image #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The postgres hba config file contains the access rules to the postgres cluster. It will be adjusted in the entry point script in future.
This allows for easier adjustments in future and for easier quoting.
Allow for more flexible configuration of the database parameters.
Always allow access via the unix domain socket and allow to configure the authentication for the access via tcp via a POSTGRES_HOST_AUTH_METHOD environment variable. By default users must be authenticated via password when using tcp and the passwords are created using the md5 authentication method.
We need to initialize the db without influence from the outside. Therefore don't allow access to the database via TCP connections for the moment.
Listen on all IP addresses of the container when starting the final db cluster. This will allow to access the database via TCP connections from the host for example when exposing the port 5432.
Avoid errors in the log when trying the create the db user twice.
For TCP access from the outside allow to set a password for the created database user.
Avoid errors when starting a container with an existing database.
Avoid errors when starting an already existing and set up database.
Conventional Commits Report
🚀 Conventional commits found. |
y0urself
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the database setup more flexible and less error prone.
Why
Allow to run the postgres cluster with TCP access and avoid printing errors to console.