Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMP doc: GET_LICENSE: add missing SENSOR reference #2264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattmundell
Copy link
Contributor

What

In the GMP doc for GET_LICENSE, add missing reference SENSOR to the PATTERN of APPLIANCE.

Also clean some elses that were making the code harder to follow.

Why

SENSOR was missing from the doc.

References

The element for SENSOR was added to the doc in 5b274d1, just the reference in PATTERN was missing.

Confirm

Using libtheia-dummy:

$ o m m '<get_license/>'
<get_license_response status="200" status_text="OK">
  <license>
    <status>200</status>
    <content>
      ...
      <appliance>
        <model>Model9</model>
        <model_type>Type11</model_type>
        <sensor>1</sensor>                <!-- HERE -->
      </appliance>

The ELSE makes it look like the first branch of the IF can fall through.
@mattmundell mattmundell requested a review from a team as a code owner July 18, 2024 20:55
Copy link

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant