Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: create_credential error case for type #2093

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Oct 9, 2023

What

When create_credential fails to determine the type, return a specific error instead of just internal error.

Why

This caught me out when I was missing the type field, and a little more of a clue would have helped. (The command is too complex to just say that the type field is missing.)

Test with something like:
o m m "<create_credential><name>eg3</name><password>eg</password></create_credential>"

... which should look like this:
o m m "<create_credential><name>eg3</name><password>eg</password><type>pw</type></create_credential>"

@mattmundell mattmundell requested a review from a team as a code owner October 9, 2023 11:42
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@timopollmeier timopollmeier merged commit 103ad42 into greenbone:main Oct 12, 2023
9 checks passed
@mattmundell mattmundell deleted the create-cred-type branch October 13, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants