Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: GET_NVTS attribute lean #2077

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Sep 12, 2023

What

Add attribute lean to GMP GET_NVTS.

Off
time oraw m m '<get_nvts lean="0" skip_tags="1" skip_cert_refs="1" details="1" timeout="1" family="General" preferences_config_id="55385e2f-cd85-4a4a-954a-c89495aca669" preference_count="1" sort_field="nvts.name" sort_order="ascending"/>' > /tmp/nvts
4.6s

On
time oraw m m '<get_nvts lean="1" skip_tags="1" skip_cert_refs="1" details="1" timeout="1" family="General" preferences_config_id="55385e2f-cd85-4a4a-954a-c89495aca669" preference_count="1" sort_field="nvts.name" sort_order="ascending"/>' > /tmp/nvts
2.5s

Why

Allows GSA to request less info for the Edit Config Family dialog. Also saves some db querying on gvmd side.

@github-actions
Copy link

Conventional Commits Report

Type Number
Added 2

🚀 Conventional commits found.

@mattmundell mattmundell marked this pull request as ready for review October 4, 2023 13:56
@mattmundell mattmundell requested a review from a team as a code owner October 4, 2023 13:56
@timopollmeier timopollmeier merged commit 215c313 into greenbone:main Oct 5, 2023
9 checks passed
@mattmundell mattmundell deleted the get-nvts-lean branch October 5, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants