Merge branch 'main' into get-nvts-lean

.github/workflows/build-and-test.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out gvmd
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Check Source Format
         run: |
           clang-format -i -style=file src/gmp_{base,delete,get,tickets}.h \
@@ -25,7 +25,7 @@ jobs:
     container: greenbone/gvmd-build:stable
     steps:
       - name: Check out gvmd
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install clang tools
         run: |
           apt update
@@ -49,7 +49,7 @@ jobs:
     container: greenbone/gvmd-build:stable
     steps:
       - name: Check out gvmd
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Build gvmd
         run: |
           cmake -B build -DCMAKE_BUILD_TYPE=Debug -DENABLE_COVERAGE=1

.github/workflows/build-container.yml

@@ -26,12 +26,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - uses: greenbone/actions/is-latest-tag@v3
         id: latest
       - name: Setup container meta information
         id: meta
-        uses: docker/metadata-action@v4
+        uses: docker/metadata-action@v5
         with:
           images: ${{ github.repository }}-build
           labels: |
@@ -63,17 +63,17 @@ jobs:
           fi
       - name: Login to DockerHub
         if: github.event_name != 'pull_request'
-        uses: docker/login-action@v2
+        uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
       - run: echo "Build and push ${{ steps.meta.outputs.tags }}"
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@v2
+        uses: docker/setup-qemu-action@v3
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v2
+        uses: docker/setup-buildx-action@v3
       - name: Build and push
-        uses: docker/build-push-action@v4
+        uses: docker/build-push-action@v5
         with:
           context: .
           push: ${{ github.event_name != 'pull_request' }}

.github/workflows/build-docs.yml

@@ -19,7 +19,7 @@ jobs:
     container: greenbone/gvmd-build:stable
     steps:
       - name: Check out gvmd
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Generate GMP documentation (HTML)
         run: |
           mkdir build

.github/workflows/codeql-analysis-c.yml

@@ -28,7 +28,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v2

.github/workflows/container.yml

@@ -16,12 +16,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - uses: greenbone/actions/is-latest-tag@v3
         id: latest
       - name: Setup container meta information
         id: meta
-        uses: docker/metadata-action@v4
+        uses: docker/metadata-action@v5
         with:
           images: ${{ github.repository }}
           labels: |
@@ -55,16 +55,16 @@ jobs:
           fi
       - name: Login to Docker Registry
         if: github.event_name != 'pull_request'
-        uses: docker/login-action@v2
+        uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@v2
+        uses: docker/setup-qemu-action@v3
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v2
+        uses: docker/setup-buildx-action@v3
       - name: Build and push Container image
-        uses: docker/build-push-action@v4
+        uses: docker/build-push-action@v5
         with:
           context: .
           push: ${{ github.event_name != 'pull_request' && (github.ref_type == 'tag' || github.ref_name == 'main') }}

INSTALL.md

@@ -508,9 +508,12 @@ Look for the current key and remember its keyid. Then:
     gpg --homedir /var/lib/gvm/gvmd/gnupg --edit-key KEYID
 
 At the prompt enter `disable` followed by `save` and `quit`.
-Then create a new key and re-encrypt all passwords:
+Then start gvmd to create a new key:
+
+    gvmd
+
+and finally re-encrypt all passwords:
 
-    gvmd --create-credentials-encryption-key
     gvmd --encrypt-all-credentials
 
 No encryption: If for backward compatibility reasons encrypted credentials

src/manage_sql.c

@@ -17464,6 +17464,10 @@ authenticate (credentials_t* credentials)
           g_free (quoted_name);
           g_free (quoted_method);
 
+          if (credentials->uuid == NULL)
+            /* Can happen if user is deleted while logged in to GSA. */
+            return 1;
+
           if (credentials_setup (credentials))
             {
               free (credentials->uuid);
@@ -20112,7 +20116,7 @@ init_host_prognosis_iterator (iterator_t* iterator, report_host_t report_host)
                  " FROM scap.cves, scap.cpes, scap.affected_products,"
                  "      report_host_details"
                  " WHERE report_host_details.report_host = %llu"
-                 " AND cpes.name = report_host_details.value"
+                 " AND LOWER(cpes.name) = LOWER(report_host_details.value)"
                  " AND report_host_details.name = 'App'"
                  " AND cpes.id=affected_products.cpe"
                  " AND cves.id=affected_products.cve"

src/schema_formats/HTML/HTML.xsl

@@ -197,7 +197,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         <xsl:text>&gt;</xsl:text>
         <xsl:call-template name="newline"/>
         <xsl:choose>
-          <xsl:when test="name() = 'help_response' or name() = 'p'">
+          <xsl:when test="name() = 'help_response' or name() = 'p' or name() = 'icalendar'">
             <!-- Special case certain responses to preserve whitespace. -->
             <xsl:variable name="string" select="func:string-trim-nl(text())"/>
             <xsl:if test="string-length($string) &gt; 0">

src/schema_formats/XML/GMP.xml.in

@@ -4994,11 +4994,17 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
       <summary>Create a schedule</summary>
       <request>
         <create_schedule>
-          <name>Every day</name>
-          <timezone>UTC</timezone>
+          <name>On the third Wednesday of every month</name>
+          <timezone>America/New_York</timezone>
           <icalendar>
-            <truncated>...</truncated>
-            DTSTART;TZID=/UTC:20200603T162600
+BEGIN:VCALENDAR
+VERSION:2.0
+PRODID:-//XXX//NONSGML//EN
+BEGIN:VEVENT
+DTSTART;TZID="America/New_York":20221214T000100
+RRULE:FREQ=MONTHLY;BYDAY=3WE;
+END:VEVENT
+END:VCALENDAR
           </icalendar>
         </create_schedule>
       </request>