Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: compress responses in exec_gmp_get #143

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Aug 29, 2023

What

In exec_gmp_get, compress responses with deflate (zlib).

Why

Speeds up data transfer by reducing size of transfer. Helps especially when the network is slow and pages are sending many MB. For example, the edit_config_family request when editing family 'Databases' with 'good 2g' throttling:

  main: 58s
  patch: 6s

@github-actions
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@mattmundell mattmundell marked this pull request as ready for review September 18, 2023 12:26
@mattmundell mattmundell requested a review from a team as a code owner September 18, 2023 12:26
@timopollmeier timopollmeier merged commit 597e9a1 into greenbone:main Oct 5, 2023
9 checks passed
@mattmundell mattmundell deleted the compress-exec-gmp-get branch October 9, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants