Removed feature toggle for compliance report views. #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
Conventional Commits Report
🚀 Conventional commits found. |
Removed the feature toggle for the dedicated compliance report views.
jhelmold
force-pushed
the
GEA-712_Remove_feature_toggle_COMPLIANCE_REPORTS_opensight
branch
from
684ee43
to
0ec8956
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## opensight-ui #4187 +/- ##
================================================
+ Coverage 64.35% 64.38% +0.02%
================================================
Files 1111 1111
Lines 103977 103926 -51
Branches 6496 6493 -3
================================================
- Hits 66917 66908 -9
+ Misses 36921 36879 -42
Partials 139 139 ☔ View full report in Codecov by Sentry. |
a-h-abdelsalam
requested changes
Nov 4, 2024
|
Quick note: if the changes are also for v24, we should open a second PR against branch |
|
@daniele-mng yes I think the changes are only needed for 24.10 and so the PR is only against |
a-h-abdelsalam
approved these changes
Nov 7, 2024
a-h-abdelsalam
deleted the
GEA-712_Remove_feature_toggle_COMPLIANCE_REPORTS_opensight
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removed the feature toggle for the dedicated compliance report views.
Why
All feature toggles are being removed for the new major release 24.10.
References
GEA-712
Checklist