Dates inconsistencies in new advance task wizard and schedules #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Files |
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4079 +/- ##
==========================================
- Coverage 72.33% 72.32% -0.02%
==========================================
Files 1068 1067 -1
Lines 122256 122228 -28
Branches 6059 6057 -2
==========================================
- Hits 88438 88404 -34
- Misses 33787 33793 +6
Partials 31 31 ☔ View full report in Codecov by Sentry. |
timopollmeier
approved these changes
Jun 25, 2024
timopollmeier
deleted the
dates-inconsistencies-in-new-task-wizard-and-schedules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR addresses two bugs:
Incorrect Duration Display in Schedules Table: The issue was with the
event.durationgetter, which incorrectly included weeks in the duration calculation, leading to inaccurate duration displays in the schedules table.Start Date Issue in Task Advance Wizard: The problem is from using
moment.day()(which returns the day of the week) instead ofmoment.date()(which returns the calendar day) when setting the start date for a new task, resulting in incorrect start dates.Why
These fixes ensure the application's scheduling and task management functionalities work as intended, preventing confusion.
References
GEA-610
Checklist