Change: Use .js as file suffix for hooks
#4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Files |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4073 +/- ##
==========================================
- Coverage 72.46% 72.45% -0.01%
==========================================
Files 1067 1068 +1
Lines 122030 121995 -35
Branches 6060 6049 -11
==========================================
- Hits 88425 88392 -33
+ Misses 33574 33572 -2
Partials 31 31 ☔ View full report in Codecov by Sentry. |
daniele-mng
reviewed
Jun 18, 2024
bjoernricks
force-pushed
the
hooks-as-js-files
branch
from
29c47cd
to
857f8ff
Compare
Hooks usually don't contain JSX and therefore should use `.js` for the file suffix. Currently this is mixed up between `.jsx` and `.js`.
Hooks should not contain JSX code and should be plain JS only. Therefore extract the ErrorMarker component from the useFormValidation module and use `js` file suffix for the module.
Just support the actual prop in use (`isVisible`) and drop passing a child.
bjoernricks
force-pushed
the
hooks-as-js-files
branch
from
857f8ff
to
6926579
Compare
daniele-mng
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use
.jsas file suffix for hooksWhy
Hooks usually don't contain JSX and therefore should use
.jsfor the file suffix. Currently this is mixed up between.jsxand.js.