Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a useDownload hook #4069

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Add a useDownload hook #4069

merged 2 commits into from
Jun 18, 2024

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jun 17, 2024

What

Add a useDownload hook

Why

The useDownload hook in conjunction with the Download component should replace the withDownload HOC in future.

References

HOCless enities pages

Checklist

  • Tests

Copy link

github-actions bot commented Jun 17, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA b3f679b.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@bjoernricks bjoernricks marked this pull request as ready for review June 17, 2024 09:32
@bjoernricks bjoernricks requested a review from a team as a code owner June 17, 2024 09:32
@bjoernricks bjoernricks enabled auto-merge (rebase) June 17, 2024 09:32
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (0ed5685) to head (77b05c4).

Current head 77b05c4 differs from pull request most recent head b3f679b

Please upload reports for the commit b3f679b to get more accurate results.

Files Patch % Lines
src/web/components/form/useDownload.jsx 91.89% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4069      +/-   ##
==========================================
- Coverage   72.44%   72.26%   -0.18%     
==========================================
  Files        1066     1066              
  Lines      121953   121747     -206     
  Branches     6047     6014      -33     
==========================================
- Hits        88351    87985     -366     
- Misses      33571    33731     +160     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The useDownload hook in conjunction with the Download component should
replace the withDownload HOC in future.
Combine Download with useDownload in a simple test.
@bjoernricks bjoernricks merged commit 97fcfeb into main Jun 18, 2024
11 checks passed
@bjoernricks bjoernricks deleted the use-download branch June 18, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants