Add: Eslint rule camelCase #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Files |
Conventional Commits Report
🚀 Conventional commits found. |
bjoernricks
approved these changes
Jun 13, 2024
It even results in failing linting at the CI because we treat warnings as errors. Should we allow warnings for now? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4062 +/- ##
==========================================
- Coverage 72.65% 72.25% -0.40%
==========================================
Files 1062 1064 +2
Lines 120912 121658 +746
Branches 5990 6002 +12
==========================================
+ Hits 87843 87899 +56
- Misses 33040 33728 +688
- Partials 29 31 +2 ☔ View full report in Codecov by Sentry. |
bjoernricks
force-pushed
the
Add-eslint-rule-camelCase-variables
branch
from
e148f55
to
fe67b9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add eslint rule for
camelCasevariables.Why
Currently, there are over 5000 instances of non-camelCase variable names in our codebase. This not only goes against JavaScript conventions but also makes our code less readable and harder to maintain. By enforcing camelCase naming, we can gradually rectify this issue and prevent it from happening in the future.
References
Checklist