Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: eslint header rule #4058

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Add: eslint header rule #4058

merged 6 commits into from
Jun 10, 2024

Conversation

daniele-mng
Copy link
Contributor

@daniele-mng daniele-mng commented Jun 7, 2024

What

Added eslint rule to check license headers of files

Why

The repository has many different licenses and out of date

References

GEA-583

Checklist

  • Tests

Copy link

github-actions bot commented Jun 7, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 170b0a3.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

package-lock.json
package.json
  • eslint-plugin-header@^3.1.1

@daniele-mng daniele-mng changed the title Add: eslint header rules Add: eslint header rule Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 98.05556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.54%. Comparing base (3c1d85e) to head (170b0a3).

Files Patch % Lines
src/gmp/index.js 0.00% 1 Missing and 1 partial ⚠️
src/index.jsx 0.00% 1 Missing and 1 partial ⚠️
src/web/app.jsx 0.00% 1 Missing and 1 partial ⚠️
scripts/cleanuptranslations.js 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4058      +/-   ##
==========================================
- Coverage   75.06%   72.54%   -2.53%     
==========================================
  Files        1058     1058              
  Lines      133069   120538   -12531     
  Branches     5927     5927              
==========================================
- Hits        99885    87439   -12446     
+ Misses      33155    33070      -85     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniele-mng daniele-mng marked this pull request as ready for review June 10, 2024 06:45
@daniele-mng daniele-mng requested a review from a team as a code owner June 10, 2024 06:45
@bjoernricks bjoernricks enabled auto-merge (rebase) June 10, 2024 06:47
@bjoernricks bjoernricks merged commit d3e9a3e into main Jun 10, 2024
12 of 13 checks passed
@bjoernricks bjoernricks deleted the Add-eslint-rules branch June 10, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants