Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a useTiming hook #4057

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Implement a useTiming hook #4057

merged 1 commit into from
Jun 12, 2024

Conversation

bjoernricks
Copy link
Contributor

What

Implement a useTiming hook

Why

The hook can be used to run a function after a specific amount of time for example for doing a reload of data.

Checklist

  • Tests

@bjoernricks bjoernricks requested a review from a team as a code owner June 7, 2024 10:29
@bjoernricks bjoernricks enabled auto-merge (rebase) June 7, 2024 10:29
Copy link

github-actions bot commented Jun 7, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 128a4d0.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Jun 7, 2024

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 92.52336% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.55%. Comparing base (90d9dc9) to head (f465ab3).
Report is 1 commits behind head on main.

Current head f465ab3 differs from pull request most recent head 128a4d0

Please upload reports for the commit 128a4d0 to get more accurate results.

Files Patch % Lines
src/web/hooks/useTiming.js 92.52% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4057      +/-   ##
==========================================
- Coverage   72.56%   72.55%   -0.01%     
==========================================
  Files        1058     1059       +1     
  Lines      120640   120645       +5     
  Branches     5932     5942      +10     
==========================================
- Hits        87541    87538       -3     
- Misses      33070    33078       +8     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The hook can be used to run a function after a specific amount of time
for example for doing a reload of data.
Copy link
Contributor

@daniele-mng daniele-mng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjoernricks bjoernricks merged commit a5a0c42 into main Jun 12, 2024
11 checks passed
@bjoernricks bjoernricks deleted the use-timing branch June 12, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants