Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: New "Port" field for SCP alert method #3833

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Aug 11, 2023

What

The alert dialog and details now have a new "Port" field for the SCP alert method.

Why

This allows using a host with a non-default SSH port as the destination.

References

GEA-280
requires greenbone/gvmd#2057 and greenbone/gsad#139

The alert dialog and details now have a new "Port" field for the
SCP alert method.
@github-actions
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #3833 (155f122) into main (c6ddd97) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3833      +/-   ##
==========================================
- Coverage   60.09%   60.09%   -0.01%     
==========================================
  Files        1023     1023              
  Lines       25151    25153       +2     
  Branches     7434     7436       +2     
==========================================
  Hits        15115    15115              
- Misses       9094     9096       +2     
  Partials      942      942              
Files Changed Coverage Δ
src/gmp/commands/alerts.js 14.28% <ø> (ø)
src/web/pages/alerts/component.js 18.58% <ø> (ø)
src/web/pages/alerts/dialog.js 20.00% <ø> (ø)
src/web/pages/alerts/method.js 16.86% <0.00%> (-0.20%) ⬇️
src/web/pages/alerts/scpmethodpart.js 33.33% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timopollmeier timopollmeier added the minor release Create a new minor release label Aug 11, 2023
@timopollmeier timopollmeier marked this pull request as ready for review August 11, 2023 07:40
@timopollmeier timopollmeier requested a review from a team as a code owner August 11, 2023 07:40
@timopollmeier timopollmeier merged commit bed0437 into main Aug 11, 2023
8 of 10 checks passed
@timopollmeier timopollmeier deleted the add-scp-alert-port branch August 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release Create a new minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants