Fix: Don't double unwrap config #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config values passed via pyproject.toml weren't being found because the config was being xx
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
|
Hi, I had a look into the config code and I am really sure you get the root of the pyproject.toml config. Thus |
|
The tests are currently failing. Could you fix them? Afterwards I would love to create a new release with your changes. |
Config values passed via pyproject.toml weren't being found because the config was being xx
auto-merge was automatically disabled
November 2, 2023 02:37
Head branch was pushed to by a user without write access
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 97.29% 97.32% +0.02%
==========================================
Files 3 3
Lines 111 112 +1
==========================================
+ Hits 108 109 +1
Misses 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
y0urself
approved these changes
Nov 2, 2023
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config values passed via
pyproject.tomlweren't being found because the config was being unwrapped twice.What
Remove an unnecessary call to
get_ruff_config.Why
The extra call was preventing config values from being applied.
References
N/A
Checklist