Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64v8 support to Dockerfile #95

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

obeone
Copy link
Contributor

@obeone obeone commented Apr 4, 2023

As describe in #93 (and #72), it wasn’t possible to run ecoCode on Apple M1/M2.

With this PR, jar are built on amd64, and put in arm64v8 and amd64 SonarQube containers. There are two main advantages :

  • Maven is not available on arm64v8, so it’s functional workaround
  • jar are built once, so power consumption is as low as possible

To be able to build locally on Apple M*, you need to use buildkit (buildx), like :

docker buildx create --use # If you don’t already have a builder
docker buildx build --load .

Github workflow is updated to build both platform

@dedece35
Copy link
Member

dedece35 commented Apr 5, 2023

Hi @obeone,
review in progress
maybe complete the doc (in this PR) with your best practices for M* Mac.

my local test : docker build -t testddc .

@obeone
Copy link
Contributor Author

obeone commented Apr 5, 2023

Hi,

Are you on Apple M ? And if it is, does this command worked ?

@dedece35
Copy link
Member

dedece35 commented Apr 9, 2023

Hi @obeone,

no, I don't have a M* Mac (only a standard MAC 2019).

@jhertout, do you know someone with a M1 or M2 MAC ?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@obeone
Copy link
Contributor Author

obeone commented Apr 9, 2023

Hi,

I can test it on a co-worker computer this week (by the way, @jhertout and I are working in the same company ;))

@github-actions
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions github-actions bot removed the stale label Sep 23, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants