Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swift version for EC528 #314

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Added Swift version for EC528 #314

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2bbf6fc
EC528 Swift port
May 30, 2024
b6b7359
EC528 Swift update
May 30, 2024
7e66515
Update EC528.asciidoc
zippy1978 May 30, 2024
e1de5e4
Merge branch 'main' into rule/EC528-swift
dedece35 May 30, 2024
298da14
Merge branch 'main' into rule/EC528-swift
dedece35 May 31, 2024
b50b775
Merge branch 'main' into rule/EC528-swift
dedece35 Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

### Added
- [#313](https://github.com/green-code-initiative/ecoCode/issues/313) [EC528] Swift port


- [#315](https://github.com/green-code-initiative/ecoCode/pull/315) Add rule EC530 for javascript
- [#321](https://github.com/green-code-initiative/ecoCode/pull/321) Add rule EC522 for javascript (avoid brightness override)
Expand Down
14 changes: 14 additions & 0 deletions ecocode-rules-specifications/src/main/rules/EC528/swift/EC528.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Shaking or vibrating an iOS device is possible using `UIFeedbackGenerator`.
Behind this effect stands a specific hardware component, the Haptic Engine, which consumes power. As a consequence, its usage should be carefully considered, especially if its added value is not clear.

== Noncompliant Code Example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for "non compliant example" ... but no "compliant example" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no there is no compliant example because the compliant example is not to use it at all :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe write it explicitly in the description at the top, no ?


[source,swift]
----
import UIKit

func triggerVibration() {
let generator = UIImpactFeedbackGenerator(style: .heavy)
generator.impactOccurred()
}
----
Loading