-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Swift version of EC512 #291
Open
zippy1978
wants to merge
10
commits into
main
Choose a base branch
from
rule/EC512-swift
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7f30520
Added Swift version of EC512
cd77dee
Added changelog entry
e775df6
Merge branch 'main' into rule/EC512-swift
dedece35 39ffdad
merged main
0b80845
Merge branch 'main' into rule/EC512-swift
dedece35 21d1c54
Merge branch 'main' into rule/EC512-swift
zippy1978 84cd7e7
Update CHANGELOG.md
zippy1978 8e219e2
Merge branch 'main' into rule/EC512-swift
dedece35 2d69a90
Merge branch 'main' into rule/EC512-swift
dedece35 37583b8
Update CHANGELOG.md
zippy1978 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
ecocode-rules-specifications/src/main/rules/EC512/swift/EC512.asciidoc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
Most iOS devices come equipped with a variety of sensors that measure motion, orientation, and various environmental conditions. | ||
Additionally, these devices include advanced sensors such as the image sensor (commonly referred to as the Camera) and the geo-positioning sensor (commonly referred to as GPS). | ||
|
||
The common point of all these sensors is that they are power-intensive while in use. A typical issue arises when these sensors continue to process data unnecessarily after the application enters an idle state, like when it is backgrounded or the user stops interacting with it. | ||
|
||
As a result, calls to manage these sensors must be carefully paired: `AVCaptureSession.startRunning()` and `AVCaptureSession.stopRunning()`. | ||
Failure to properly manage these calls can lead to significant battery drain within a few hours. | ||
|
||
== Noncompliant Code Example | ||
|
||
[source,swift] | ||
---- | ||
import AVFoundation | ||
|
||
class CameraManager { | ||
var captureSession: AVCaptureSession? | ||
|
||
func activateCamera() { | ||
captureSession = AVCaptureSession() | ||
captureSession?.startRunning() // Camera starts capturing | ||
// Missing corresponding stopRunning | ||
} | ||
} | ||
---- | ||
|
||
== Compliant Code Example | ||
|
||
[source,swift] | ||
---- | ||
import AVFoundation | ||
|
||
class CameraManager { | ||
var captureSession: AVCaptureSession? | ||
|
||
func activateCamera() { | ||
captureSession = AVCaptureSession() | ||
captureSession?.startRunning() // Camera starts capturing | ||
} | ||
|
||
func deactivateCamera() { | ||
captureSession?.stopRunning() // Camera stops capturing | ||
} | ||
} | ||
---- |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicates here too