Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules.md: Refused rules #234

Merged
merged 10 commits into from
Nov 16, 2023
Merged

Rules.md: Refused rules #234

merged 10 commits into from
Nov 16, 2023

Conversation

jhertout
Copy link
Contributor

  • Add a section for refused rules
  • Invalidate rule EC66 for Python and a dd a link in the array to the justification

See Rules.md

@jhertout jhertout requested a review from dedece35 October 19, 2023 05:21
utarwyn
utarwyn reviewed Oct 20, 2023
View reviewed changes
RULES.md Outdated Show resolved Hide resolved
RULES.md Show resolved Hide resolved
utarwyn
utarwyn previously approved these changes Oct 20, 2023
View reviewed changes
@utarwyn utarwyn added the 🗒️ documentation Improvements or additions to documentation label Oct 20, 2023
dedece35
dedece35 requested changes Oct 20, 2023
View reviewed changes
RULES.md Outdated

This table lists rules proposed by the community but refused in ecoCode plugins with the justification.

| Name | Description | Language | Invalidation |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have put the language column as first column, no ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forget this one, I will update that.

@dedece35 dedece35 mentioned this pull request Oct 27, 2023
Closed
@dedece35
Copy link
Member

@jhertout please make correction of conflicts

@jhertout
Copy link
Contributor Author

Damned!

@jhertout
Copy link
Contributor Author

Please wait, the merge did not work as I expected.

@jhertout
Copy link
Contributor Author

Must be OK this time

dedece35
dedece35 previously approved these changes Nov 10, 2023
View reviewed changes
@dedece35 dedece35 dismissed their stale review November 10, 2023 15:53

please add CHANGELOG.md update

@dedece35
Copy link
Member

@jhertout
Even If I approve one review, I will never merge myself the PR : I let the commiter merge his PR to control when he wants to merge.
but before approving, please update CHANGELOG.md :p

@jhertout
Copy link
Contributor Author

Yes, I see your message. I did not have the time to do it Friday, I was on an hurry. I will look at that as soon as I can :).

@jhertout
Copy link
Contributor Author

Done

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jhertout jhertout merged commit d0d2777 into green-code-initiative:main Nov 16, 2023
3 checks passed
@jhertout jhertout deleted the refused_rules_justification branch November 16, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedece35 dedece35 dedece35 approved these changes

@utarwyn utarwyn utarwyn left review comments

Assignees

@jhertout jhertout

Labels
🗒️ documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhertout @dedece35 @utarwyn