Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 208 better build #213

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Feature/issue 208 better build #213

merged 10 commits into from
Oct 18, 2024

Conversation

jycr
Copy link
Contributor

@jycr jycr commented Jul 21, 2023 •
edited
Loading

fix #208

@dedece35 dedece35 self-requested a review July 26, 2023 07:50
@dedece35 dedece35 added 🚀 enhancement New feature or request 🏗️ refactoring refactoring for best practices labels Jul 26, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 8, 2023
@dedece35
Copy link
Member

Hi @jycr,
sorry but we have to discuss about this feature because I don't know it and I have some questions.

@jycr jycr force-pushed the feature/ISSUE-208--better-build branch from f575288 to 214ff70 Compare October 22, 2023 15:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jycr
Copy link
Contributor Author

jycr commented Oct 22, 2023 •
edited
Loading

Hi @jycr, sorry but we have to discuss about this feature because I don't know it and I have some questions.

@dedece35: No problem to discuss it together.
But we can wait to split java-plugin into its own repo before finishing this PR?

@dedece35
Copy link
Member

dedece35 commented Oct 22, 2023 •
edited
Loading

Hi @jycr, sorry but we have to discuss about this feature because I don't know it and I have some questions.

@dedece35: No problem to discuss it together. But we can wait to split java-plugin into its own repo before finishing this PR?

@jycr ... yes I think we should wait automatic release PR (#209) before merging this one

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 22, 2023
@dedece35 dedece35 marked this pull request as draft December 1, 2023 21:41
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot removed the stale label Dec 2, 2023
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has no activity for 60 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 14, 2024
@jycr jycr mentioned this pull request Jun 2, 2024
Closed
@jycr jycr force-pushed the feature/ISSUE-208--better-build branch from 8733160 to 4a61a7a Compare September 2, 2024 11:36
@jycr jycr force-pushed the feature/ISSUE-208--better-build branch from 4a61a7a to 63fb3b4 Compare September 2, 2024 13:39
@jycr jycr marked this pull request as ready for review September 2, 2024 13:45
@jycr jycr force-pushed the feature/ISSUE-208--better-build branch from 63fb3b4 to e4254b6 Compare September 2, 2024 14:06
dedece35
dedece35 previously approved these changes Oct 4, 2024
View reviewed changes
@jycr jycr force-pushed the feature/ISSUE-208--better-build branch from e4254b6 to 005165a Compare October 10, 2024 12:28
@jycr jycr requested a review from dedece35 October 10, 2024 12:35
dedece35
dedece35 requested changes Oct 11, 2024
View reviewed changes
.mvn/extensions.xml Outdated Show resolved Hide resolved
dedece35
dedece35 requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an update in CHANGELOG.md, please

jycr added 8 commits October 18, 2024 14:48
@jycr
Uses Maven CI Friendly Versions
c177456 
More information:
* [Maven CI Friendly Versions - Apache Maven Project](https://maven.apache.org/maven-ci-friendly.html)
* [Maven Git Versioning Extension](https://github.com/qoomon/maven-git-versioning-extension)
@jycr
⚰️ Removes scripts for release management.
4f8e60f 
The release process is now much simpler: you just need to do a build on a tag checkout

The `pom.xml` files do not need to be modified anymore. So there is no need to create commits just for the version change in the `pom.xml`
@jycr
Ensures build reproducibility
0d2e255 
More information:
* [Configuring for Reproducible Builds - Apache Maven Project](https://maven.apache.org/guides/mini/guide-reproducible-builds.html)
@jycr
[ecoCode#336] Adds Maven Wrapper
31e0e70 
This Maven Wrapper is an easy way to ensure a developer has everything necessary to build this project.

Executed command to add wrapper to project:

```sh
mvn wrapper:wrapper -Dmaven=3.9.9
```
@jycr
Migrates scripts to use Maven Wrapper (to ensure consistency of Maven…
30b3dce 
… version used across different environments)
@jycr
Updates asciidoctor-maven-plugin to 3.0.0
31f4e08 
This version fixes false positive warning `[WARNING] Duplicated destination found: overwriting file`
@jycr
Refactor pom.xml to uncomment <plugins> section but keep `license-m…
def7cda 
…aven-plugin` commented
@jycr
Add an enforcer rule based on plugin requirements on the minimum Mave…
9bb275d 
…n version needed
@jycr jycr force-pushed the feature/ISSUE-208--better-build branch from 6ba38a6 to 9516081 Compare October 18, 2024 13:15
@jycr jycr force-pushed the feature/ISSUE-208--better-build branch from 9516081 to a0264ec Compare October 18, 2024 13:15
@jycr
Copy link
Contributor Author

jycr commented Oct 18, 2024

add an update in CHANGELOG.md, please

I have added:

#208 Improves build process with Maven Wrapper and simplifies release management (now, just need to do a build on a tag checkout).
If you have difficulties on some IDEs (like IntelliJ IDEA), you can follow the procedure: configuration for Multi Modules Project

Do you need me to add any further details?

@dedece35
Copy link
Member

add an update in CHANGELOG.md, please

I have added:

#208 Improves build process with Maven Wrapper and simplifies release management (now, just need to do a build on a tag checkout).
If you have difficulties on some IDEs (like IntelliJ IDEA), you can follow the procedure: configuration for Multi Modules Project

Do you need me to add any further details?

no, sorry, my bad ... i didn't see it :(

@jycr jycr merged commit 3dabdcc into main Oct 18, 2024
1 check passed
@jycr jycr deleted the feature/ISSUE-208--better-build branch October 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedece35 dedece35 dedece35 approved these changes

Assignees

@jycr jycr

Labels
🏗️ refactoring refactoring for best practices 🚀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use "Maven Friendly Version"
2 participants
@jycr @dedece35