Remove rule EC4 for Java because not applicable

green-code-initiative · Nov 21, 2023 · 9fef634 · 9fef634
1 parent e52fd18
commit 9fef634
Show file tree

Hide file tree

Showing 9 changed files with 7 additions and 173 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Deleted
 
+- [#243](https://github.com/green-code-initiative/ecoCode/pull/243) Remove rule EC4 for Java because not applicable
+
 ## [1.4.0] - 2023-08-08
 
 ### Added

diff --git a/RULES.md b/RULES.md
@@ -29,7 +29,7 @@ Some are applicable for different technologies.
 | EC35     | Using try...catch calls (on File Not Found Exception)                                                      | When an exception is thrown, a variable (the exception itself) is created in the catch block and destroyed at the end of the block.  Creating this variable and destroying it consumes CPU cycles and RAM unnecessarily. That is why it is important not to use this construction and to prefer, as much as possible, a logical test.  This new rule replace old EC34 only for a particular use case (FileNotFoundException) | [cnumr best practices (3rd edition) BP_047 (no longer exists in edition 4)](https://www.greenit.fr/2019/05/07/ecoconception-web-les-115-bonnes-pratiques-3eme-edition/) | 🚀   | ✅   | 🚀 | ✅      | 🚀   |
 | EC22     | The use of methods for basic operations                                                                    | Using methods for basic operations consumes additional system resources. The interpreter must in effect and solve the objects and then the methods, just to carry out these simple operations of the language.                                                                                                                                                                                                               | [cnumr best practices (3rd edition) BP_048 (no longer exists in edition 4)](https://www.greenit.fr/2019/05/07/ecoconception-web-les-115-bonnes-pratiques-3eme-edition/) | 🚀   | ✅   | 🚀 | 🚀     | 🚀   |
 | ???      | Call a DOM element multiple times without caching (linter key : `@ecocode/no-multiple-access-dom-element`) | Access to the Document Object Model (DOM) is costly in terms of CPU resources (CPU cycles). Also, when you use the same DOM element from JavaScript multiple times, store its reference in a variable so that you do not go through the DOM again for the same element.                                                                                                                                                      | [cnumr best practices (3rd edition) BP_049](https://github.com/cnumr/best-practices/blob/main/chapters/BP_049_fr.md)                                                    | 🚫   | 🚫  | ✅  | 🚫     | 🚫   |
-| EC4      | Use global variables                                                                                       | When using a global variable, the interpretation engine must check:  1) that it exists in the current scope, in the one above, etc. ; 2) the variable has a value; 3) ... To avoid all these checks, it is often possible to pass the useful variables as arguments of routines, making them local.  This process saves computational time (CPU cycles).                                                                     | [cnumr best practices (3rd edition) BP_050 (no longer exists in edition 4)](https://www.greenit.fr/2019/05/07/ecoconception-web-les-115-bonnes-pratiques-3eme-edition/) | ✅    | ✅   | 🚀 | ✅      | 🚀   |
+| EC4      | Use global variables                                                                                       | When using a global variable, the interpretation engine must check:  1) that it exists in the current scope, in the one above, etc. ; 2) the variable has a value; 3) ... To avoid all these checks, it is often possible to pass the useful variables as arguments of routines, making them local.  This process saves computational time (CPU cycles).                                                                     | [cnumr best practices (3rd edition) BP_050 (no longer exists in edition 4)](https://www.greenit.fr/2019/05/07/ecoconception-web-les-115-bonnes-pratiques-3eme-edition/) | 🚫    | ✅   | 🚀 | ✅      | 🚀   |
 | EC53     | Using arrays in foreach loops                                                                              | foreach deduplicates items in a list before starting the enumeration. It is therefore generally more economical to use a simple for loop when you have a good command of the collection.                                                                                                                                                                                                                                     | [cnumr best practices (3rd edition) BP_053 (no longer exists in edition 4)](https://www.greenit.fr/2019/05/07/ecoconception-web-les-115-bonnes-pratiques-3eme-edition/) | ✅    | 🚀  | 🚀 | 🚫     | 🚀   |
 | EC7      | Rewrite native getter/setters                                                                              | Overloading them lengthens the compilation and execution times of these methods, which are usually much better optimized by the language than by the developer.                                                                                                                                                                                                                                                              | [cnumr best practices (3rd edition) BP_062 (no longer exists in edition 4)](https://www.greenit.fr/2019/05/07/ecoconception-web-les-115-bonnes-pratiques-3eme-edition/) | 🚀   | 🚀  | 🚀 | ✅      | 🚀   |
 | EC63     | Unnecessarily assigning values to variables                                                                | Avoid declaring and using variables when it is not indis-thinkable.  Indeed, each allocation corresponds to the RAM occupied.                                                                                                                                                                                                                                                                                                | [cnumr best practices (3rd edition) BP_063 (no longer exists in edition 4)](https://www.greenit.fr/2019/05/07/ecoconception-web-les-115-bonnes-pratiques-3eme-edition/) | ✅    | 🚀  | 🚀 | 🚀     | 🚀   |
@@ -65,3 +65,4 @@ This table lists rules proposed by the community but refused in ecoCode plugins
 |----------|------------------------------------------|------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------|
 | Python   | Use numpy array instead of standard list | The use of numpy library to perform array manipulation is more energy efficient than the use of the standard list functions. | [Github discussion with measures](https://github.com/green-code-initiative/ecoCode/issues/132) |
 | HTML     | HTML page must contain a doctype tag     | The difference in performance is negligible, this rule is more related to the user experience.                               | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/issues/103)  |
+| Java     | Avoid using global variables             | Global variables do not exist in Java.                                                                                       | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/issues/233)  |
diff --git a/ecocode-rules-specifications/src/main/rules/EC4/java/EC4.asciidoc b/ecocode-rules-specifications/src/main/rules/EC4/java/EC4.asciidoc
diff --git a/java-plugin/src/main/java/fr/greencodeinitiative/java/JavaCheckRegistrar.java b/java-plugin/src/main/java/fr/greencodeinitiative/java/JavaCheckRegistrar.java
@@ -31,7 +31,6 @@
 import fr.greencodeinitiative.java.checks.AvoidSpringRepositoryCallInLoopCheck;
 import fr.greencodeinitiative.java.checks.AvoidStatementForDMLQueries;
 import fr.greencodeinitiative.java.checks.AvoidUsageOfStaticCollections;
-import fr.greencodeinitiative.java.checks.AvoidUsingGlobalVariablesCheck;
 import fr.greencodeinitiative.java.checks.FreeResourcesOfAutoCloseableInterface;
 import fr.greencodeinitiative.java.checks.IncrementCheck;
 import fr.greencodeinitiative.java.checks.InitializeBufferWithAppropriateSize;
@@ -67,7 +66,6 @@ public class JavaCheckRegistrar implements CheckRegistrar {
             UnnecessarilyAssignValuesToVariables.class,
             OptimizeReadFileExceptions.class,
             InitializeBufferWithAppropriateSize.class,
-            AvoidUsingGlobalVariablesCheck.class,
             AvoidSetConstantInBatchUpdate.class,
             FreeResourcesOfAutoCloseableInterface.class,
             AvoidMultipleIfElseStatement.class

diff --git a/...ugin/src/main/java/fr/greencodeinitiative/java/checks/AvoidUsingGlobalVariablesCheck.java b/...ugin/src/main/java/fr/greencodeinitiative/java/checks/AvoidUsingGlobalVariablesCheck.java
diff --git a/java-plugin/src/test/files/AvoidUsingGlobalVariablesCheck.java b/java-plugin/src/test/files/AvoidUsingGlobalVariablesCheck.java
diff --git a/java-plugin/src/test/java/fr/greencodeinitiative/java/JavaCheckRegistrarTest.java b/java-plugin/src/test/java/fr/greencodeinitiative/java/JavaCheckRegistrarTest.java
@@ -31,7 +31,7 @@ void checkNumberRules() {
         final JavaCheckRegistrar registrar = new JavaCheckRegistrar();
         registrar.register(context);
 
-        assertThat(context.checkClasses()).hasSize(19);
+        assertThat(context.checkClasses()).hasSize(18);
         assertThat(context.testCheckClasses()).isEmpty();
     }
 

diff --git a/java-plugin/src/test/java/fr/greencodeinitiative/java/JavaRulesDefinitionTest.java b/java-plugin/src/test/java/fr/greencodeinitiative/java/JavaRulesDefinitionTest.java
@@ -78,12 +78,12 @@ void testMetadata() {
         assertThat(repository.name()).isEqualTo("ecoCode");
         assertThat(repository.language()).isEqualTo("java");
         assertThat(repository.key()).isEqualTo("ecocode-java");
-        assertThat(repository.rules()).hasSize(19);
+        assertThat(repository.rules()).hasSize(18);
     }
 
     @Test
     void testRegistredRules() {
-        assertThat(repository.rules()).hasSize(19);
+        assertThat(repository.rules()).hasSize(18);
     }
 
     @Test

diff --git a/...test/java/fr/greencodeinitiative/java/checks/AvoidUsingGlobalVariablesCheckCheckTest.java b/...test/java/fr/greencodeinitiative/java/checks/AvoidUsingGlobalVariablesCheckCheckTest.java