[PR 128-ecocode] replace EC34 by EC35 : update CHANGELOG, update rule…

… specifications
green-code-initiative · Oct 21, 2023 · 745f6ad · 745f6ad
1 parent 16d1c90
commit 745f6ad
Show file tree

Hide file tree

Showing 7 changed files with 50 additions and 47 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [#136](https://github.com/green-code-initiative/ecoCode/issues/136) Upgrade rule EC53 for Python : no implementation possible for python
 
 ### Deleted
+- [#128](https://github.com/green-code-initiative/ecoCode/pull/128) Delete rule EC34 for Python and PHP : rule replaced by EC35 ("file not found" sepcific) 
 
 ## [1.4.0] - 2023-08-08
 

diff --git a/RULES.md b/RULES.md
diff --git a/ecocode-rules-specifications/pom.xml b/ecocode-rules-specifications/pom.xml
@@ -64,7 +64,7 @@
 					ASCIIDOC format is used with custom features such as :
 					- syntax highlighting (see code blocks on ASCIIDOC rules)
 					- inclusions (see: php/EC74.asciidoc)
-					- table data generation from CSV (see: php/EC34.asciidoc)
+					- table data generation from CSV (see: php/EC35.asciidoc)
 				-->
 				<groupId>org.asciidoctor</groupId>
 				<artifactId>asciidoctor-maven-plugin</artifactId>

diff --git a/...cifications/src/main/rules/EC34/EC34.json → ...cifications/src/main/rules/EC35/EC35.json b/...cifications/src/main/rules/EC34/EC34.json → ...cifications/src/main/rules/EC35/EC35.json
@@ -1,5 +1,5 @@
 {
-  "title": "Avoid using try-catch statement",
+  "title": "Avoid using try-catch statement with file open operation in try block",
   "type": "CODE_SMELL",
   "status": "ready",
   "remediation": {

diff --git a/...s/src/main/rules/EC34/php/1GB.etsdiff.csv → ...s/src/main/rules/EC35/php/1GB.etsdiff.csv b/...s/src/main/rules/EC34/php/1GB.etsdiff.csv → ...s/src/main/rules/EC35/php/1GB.etsdiff.csv
diff --git a/...ons/src/main/rules/EC34/php/EC34.asciidoc → ...ons/src/main/rules/EC35/php/EC35.asciidoc b/...ons/src/main/rules/EC34/php/EC34.asciidoc → ...ons/src/main/rules/EC35/php/EC35.asciidoc
@@ -1,4 +1,5 @@
-Inside complex code parts (for exemple multiple loops, complex data constructions...), avoid using try...catch...finally.
+Inside complex code parts (for exemple multiple loops, complex data constructions...), avoid using try...catch.
+For the moment, this rule only deals with "file open" use case in try...catch blocks.
 
 When an exception is thrown, a variable (the exception itself) is created in a catch block and it's destruction consumes unnecessary CPU cycles and RAM. Prefer using logical tests in this cases.
 

diff --git a/.../src/main/rules/EC34/python/EC34.asciidoc → .../src/main/rules/EC35/python/EC35.asciidoc b/.../src/main/rules/EC34/python/EC34.asciidoc → .../src/main/rules/EC35/python/EC35.asciidoc
@@ -1,4 +1,5 @@
-Inside complex code parts (for example multiple loops, complex data constructions...), avoid using try...catch...finally.
+Inside complex code parts (for example multiple loops, complex data constructions...), avoid using try...catch.
+For the moment, this rule only deals with "file open" use case in try...catch blocks.
 
 When an exception is thrown, a variable (the exception itself) is created in a catch block, and it's destruction consumes unnecessary CPU cycles and RAM. Prefer using logical tests in this cases.