Skip to content

Commit

Permalink
[ISSUE 123] complete unit tests for EC7 rule
Browse files Browse the repository at this point in the history
  • Loading branch information
dedece35 committed Dec 15, 2023
1 parent 7b1463e commit 761ce46
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public class AvoidGettersAndSettersTest {

@Test
public void test() {
PythonCheckVerifier.verify("src/test/resources/checks/avoidGettersAndSetters.py", new AvoidGettersAndSetters());
PythonCheckVerifier.verifyNoIssue("src/test/resources/checks/avoidGettersAndSettersCompliant.py", new AvoidGettersAndSetters());
PythonCheckVerifier.verify("src/test/resources/checks/avoidGettersAndSettersNonCompliant.py", new AvoidGettersAndSetters());
}
}
20 changes: 20 additions & 0 deletions src/test/resources/checks/avoidGettersAndSettersCompliant.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
from datetime import date

class Client():

def __init__(self, age, weight):
self.age = age
self.weight = weight

def get_age_in_five_years(self):
a = Client()
return a.age

def is_major(self):
return self.age >= 18

client = Client(25)
client.age
client.age = 25
client.weight
client.weight(5)
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,9 @@ def is_major(self):

def get_weight(self): # Noncompliant {{Avoid creating getter and setter methods in classes}}
return self.weight

client = Client(25)
client.get_age()
client.set_age(25)
client.get_weight()
client.set_weight(5)

0 comments on commit 761ce46

Please sign in to comment.