Merge branch 'main' into ISSUE_4

green-code-initiative · Dec 15, 2023 · 16cae3e · 16cae3e
2 parents 170e25f + 2e86afb
commit 16cae3e
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,7 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [#5](https://github.com/green-code-initiative/ecoCode-python/pull/5) Upgrade licence system and licence headers of Java files
 - [#6](https://github.com/green-code-initiative/ecoCode-python/pull/6) Adding EC35 rule : EC35 rule replaces EC34 with a specific use case ("file not found" sepcific)
 - [#7](https://github.com/green-code-initiative/ecoCode-python/issues/7) Add build number to manifest
-- Update ecocode-rules-specifications to 0.0.9
+- [#123](https://github.com/green-code-initiative/ecoCode/issues/123) Imprive unit tests for EC7 rule
+- Update ecocode-rules-specifications to 0.0.10
 
 ### Deleted
 

diff --git a/pom.xml b/pom.xml
@@ -59,7 +59,7 @@
         <mockito.version>5.3.1</mockito.version>
 
         <!-- temporary version waiting for real automatic release in ecocode repository -->
-        <ecocode-rules-specifications.version>0.0.9</ecocode-rules-specifications.version>
+        <ecocode-rules-specifications.version>0.0.10</ecocode-rules-specifications.version>
 
         <sonar-analyzer-commons.version>2.5.0.1358</sonar-analyzer-commons.version>
 

diff --git a/src/test/java/fr/greencodeinitiative/python/checks/AvoidGettersAndSettersTest.java b/src/test/java/fr/greencodeinitiative/python/checks/AvoidGettersAndSettersTest.java
@@ -24,6 +24,7 @@ public class AvoidGettersAndSettersTest {
 
     @Test
     public void test() {
-        PythonCheckVerifier.verify("src/test/resources/checks/avoidGettersAndSetters.py", new AvoidGettersAndSetters());
+        PythonCheckVerifier.verifyNoIssue("src/test/resources/checks/avoidGettersAndSettersCompliant.py", new AvoidGettersAndSetters());
+        PythonCheckVerifier.verify("src/test/resources/checks/avoidGettersAndSettersNonCompliant.py", new AvoidGettersAndSetters());
     }
 }
diff --git a/src/test/resources/checks/avoidGettersAndSettersCompliant.py b/src/test/resources/checks/avoidGettersAndSettersCompliant.py
@@ -0,0 +1,20 @@
+from datetime import date
+
+class Client():
+
+    def __init__(self, age, weight):
+        self.age = age
+        self.weight = weight
+
+    def get_age_in_five_years(self):
+        a = Client()
+        return a.age
+
+    def is_major(self):
+        return self.age >= 18
+
+client = Client(25)
+client.age
+client.age = 25
+client.weight
+client.weight(5)
diff --git a/...esources/checks/avoidGettersAndSetters.py → ...cks/avoidGettersAndSettersNonCompliant.py b/...esources/checks/avoidGettersAndSetters.py → ...cks/avoidGettersAndSettersNonCompliant.py
@@ -24,3 +24,9 @@ def is_major(self):
 
     def get_weight(self): # Noncompliant {{Avoid creating getter and setter methods in classes}}
         return self.weight
+
+client = Client(25)
+client.get_age()
+client.set_age(25)
+client.get_weight()
+client.set_weight(5)