fix: 🐛 Fix issues #228 #233 #235 #240

[alograg]

Remove depreciated rules seen in issues, refer to discussion (green-code-initiative/creedengo-rules-specifications#271)

[dedece35]

Hi @alograg,
thank you a lot for PR.
there are some lacks to remove deprecated rules : I want to write a DefinitionOfDone list (like https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#definition-of-done-of-a-pr ) to check all work to do in order to delete deprecated rules (issue created for that : green-code-initiative/creedengo-common#28 )

here are lacks that I detected :

• check exiting DoD list : https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#definition-of-done-of-a-pr
  • create also a PR on repository https://github.com/green-code-initiative/ecoCode-java-test-project because it's a project to check all is ok on an real environment and not also with Unit Tests
  • CHANGELOG.md update
• add a new PR on ecocode repository to delete documentation rules (for example here : https://github.com/green-code-initiative/ecoCode/tree/main/ecocode-rules-specifications/src/main/rules/EC63 )
  • modification in this repository is very important because it is referenced on pom.xml of each plugin repository
  • a new release has to be done to be used in repository plugin (here is the process : https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/INSTALL.md#howto-publish-a-new-version-of-ecocode-rules-specifications-on-maven-central )

[dedece35]

please update CHANGELOG.md in "unreleased" part with these deletions.

[dedece35]

Hi @alograg,
please take into account all my previous unresolved notes.

Once, you will correct my only one review feedback on "ecoCode-rules-specifications" repository, I will create a new version 1.5.0 of this one.
Next, this PR will be ok on Checks Tab.
(please, correct conflicts in this PR)

Thank you again !

[alograg]

Hi @dedece35
This is ok ?
Maybe I was wrong about something regarding the POM versions.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[dedece35]

Hi @alograg,
thank you again for your work.
the new 1.6.0 java release contains your work : check https://github.com/green-code-initiative/ecoCode-java/releases/tag/1.6.0

[alograg]

Thankyou @dedece35

I am truly humbled and honored to have received such positive feedback from you.

It has been a pleasure to participate in the EcoCode community and I am grateful for the opportunity to contribute to such a valuable project.

I am committed to continuing to contribute to the community in any way that I can. I am always looking for new ways to improve my skills and knowledge, and I am eager to share what I have learned with others.

Thank you again for your support and encouragement. I am excited to continue working with you and the rest of the community.