Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHALLENGE24][Samarium] Implement rules EC82, EC205, EC1245 #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

massiltag
Copy link

No description provided.

massiltag added 2 commits May 29, 2024 17:47
EC1245 : Avoid energy consuming methods check
EC82 : Make non reassigned variable constants
CRJVM205 : Force Lazy fetch types for JPA entity associations
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@dedece35
Copy link
Member

dedece35 commented Jan 3, 2025

Hi @massiltag,
thank you for your work but I must merge your work with some other PRs dealing with Java EC82 rule.
I created the new PR #89 for EC82 rule part.

This new rule is now available for the next release of the Java plugin.

Thank you a lot.

PS : all the PR dealing with EC82 rule which have been merged into the new above PR :

PS2 : I will work soon on the two other parts of your PR (EC205 and EC1245)

@dedece35
Copy link
Member

dedece35 commented Jan 3, 2025

@massiltag

for EC1245 rule, I understand the implementation, but I need a prove to accept your implementation. Di you have some issue or web documentation relating your list of sentences to avoid ?

@github-actions github-actions bot removed the stale label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants