feat(Rules): key updates

green-code-initiative · Mar 18, 2024 · 5f0afb8 · 5f0afb8
1 parent fa3edd0
commit 5f0afb8
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 50 deletions.
diff --git a/swift-lang/src/main/java/io/ecocode/ios/swift/checks/sobriety/AnimationFreeCheck.java b/swift-lang/src/main/java/io/ecocode/ios/swift/checks/sobriety/AnimationFreeCheck.java
@@ -29,7 +29,7 @@
 /**
  * Check the use of "UIScreen.main.brightness" and triggers when set.
  */
-@Rule(key = "ESOB007")
+@Rule(key = "EC603")
 public class AnimationFreeCheck extends SwiftRuleCheck {
 
     private static final String DEFAULT_ISSUE_MESSAGE = "Usage of Animations must absolutely be avoided";

diff --git a/swift-lang/src/main/java/io/ecocode/ios/swift/checks/sobriety/TorchFreeCheck.java b/swift-lang/src/main/java/io/ecocode/ios/swift/checks/sobriety/TorchFreeCheck.java
@@ -25,7 +25,7 @@
 /**
  * Check the use of "AVCaptureTorchMode.on", "setTorchModeOn(level: Float)", or "torchMode = .on" and triggers when set to true.
  */
-@Rule(key = "EC23")
+@Rule(key = "EC503")
 public class TorchFreeCheck extends SwiftRuleCheck {
     private static final String DEFAULT_ISSUE_MESSAGE = "Usage of `AVCaptureDevice#torchMode` or `AVCaptureDevice#setTorchModeOn(level:)` must absolutely be avoided";
     @Override

diff --git a/swift-lang/src/main/resources/io/ecocode/rules/swift/ESOB007.html b/swift-lang/src/main/resources/io/ecocode/rules/swift/ESOB007.html
diff --git a/swift-lang/src/main/resources/io/ecocode/rules/swift/ESOB007.json b/swift-lang/src/main/resources/io/ecocode/rules/swift/ESOB007.json
diff --git a/swift-lang/src/test/java/io/ecocode/ios/swift/EcoCodeSwiftRulesDefinitionTest.java b/swift-lang/src/test/java/io/ecocode/ios/swift/EcoCodeSwiftRulesDefinitionTest.java
@@ -60,7 +60,7 @@ public void testRegisteredRules() {
 
     @Test
     public void assertRuleProperties() {
-        Rule rule = repository.rule("ESOB007");
+        Rule rule = repository.rule("EC603");
         assertThat(rule).isNotNull();
         assertThat(rule.name()).isEqualTo("Animation Methods in UIKit and SwiftUI");
         assertThat(rule.debtRemediationFunction().type()).isEqualTo(Type.CONSTANT_ISSUE);

diff --git a/swift-lang/src/test/java/io/ecocode/ios/swift/checks/sobriety/AnimationFreeCheckTest.java b/swift-lang/src/test/java/io/ecocode/ios/swift/checks/sobriety/AnimationFreeCheckTest.java
@@ -83,7 +83,7 @@ private void assertAnimationFreeIssue(String file, int line) {
     }
 
     private void assertIssue(Issue issue, int line) {
-        assertThat(issue.ruleKey().rule()).isEqualTo("ESOB007");
+        assertThat(issue.ruleKey().rule()).isEqualTo("EC603");
         assertThat(issue.ruleKey().repository()).isEqualTo("ecoCode-swift");
         IssueLocation location = issue.primaryLocation();
         assertThat(location.textRange().start().line()).isEqualTo(line);

diff --git a/swift-lang/src/test/java/io/ecocode/ios/swift/checks/sobriety/TorchFreeCheckTest.java b/swift-lang/src/test/java/io/ecocode/ios/swift/checks/sobriety/TorchFreeCheckTest.java
@@ -57,7 +57,7 @@ private void assertTorchIssue(String file, int line) {
     }
 
     private void assertIssue(Issue issue, int line) {
-        assertThat(issue.ruleKey().rule()).isEqualTo("EC23");
+        assertThat(issue.ruleKey().rule()).isEqualTo("EC503");
         assertThat(issue.ruleKey().repository()).isEqualTo("ecoCode-swift");
         IssueLocation location = issue.primaryLocation();
         assertThat(location.textRange().start().line()).isEqualTo(line);