Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed osx WebView.mm not for avoiding race condition about bitmap. #601

Merged
merged 1 commit into from
Oct 14, 2020
Merged

fixed osx WebView.mm not for avoiding race condition about bitmap. #601

merged 1 commit into from
Oct 14, 2020

Conversation

KojiNakamaru
Copy link
Member

cf. #599

In update: method, bitmap could be updated in takeSnapshotWithConfiguration completionHandler without any synchronization and render: might use bitmap in incomplete state. This patch adds synchronization and more carefully updates needsDisplay.

@KojiNakamaru KojiNakamaru merged commit a14c82a into master Oct 14, 2020
@KojiNakamaru KojiNakamaru deleted the fix/osx_takesnapshot branch October 14, 2020 17:00
@KojiNakamaru KojiNakamaru mentioned this pull request Oct 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KojiNakamaru