Allow Control-C to gracefully exit a Facedancer emulation #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve the tension between:
--suggest
argument to work and b) just having something nicer than crashing out of the emulation with aSIGINT
versus…I propose that we dedicate an unused key-combination (at the time of writing this isControl-E
) that can be polled for in anexit_handler()
co-routine.The final approach taken is to catch the
KeyboardInterrupt
exception in thedefault_main()
helper function allowing users to gracefully exit from the emulation by pressingControl-C
.For users who may require different behavior a new example has been added:
examples/coroutine.py
which demonstrates how to write a customdefault_main
function and the use of coroutines.Closes #118