Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace explicit Yajl support with MultiJson #73

Closed
wants to merge 1 commit into from

Conversation

milgner
Copy link
Contributor

@milgner milgner commented Mar 18, 2018

Replacement for #64

By using MultiJson, one can use oj or other JSON libraries besides yajl, too.

@tessie are you fine with introducing another dependency here?

@milgner milgner self-assigned this Mar 18, 2018
@milgner milgner requested a review from tessie March 18, 2018 21:53
@CLAassistant
Copy link

CLAassistant commented Mar 18, 2018

CLA assistant check
All committers have signed the CLA.

@milgner
Copy link
Contributor Author

milgner commented Mar 26, 2018

On further thought, I'll make multi-json optional, too... just stumbled over https://github.com/ruby-grape/grape/pull/1623/files and found myself really liking their appraisal mechanism. Will check evaluate it for this gem as well...

@milgner
Copy link
Contributor Author

milgner commented Apr 6, 2018

As MultiJSON is somewhat deprecated by the original author, I'll close this for now.

@milgner milgner closed this Apr 6, 2018
@repeatedly
Copy link

repeatedly commented Oct 26, 2018

How about other approach like #64?
New gelf-rb breaks fluentd and it also breaks their k8s/fluentd/graylog setup so we need new gelf-rb with #63 fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants