Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 support to the UDP sender #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ferrous26
Copy link

And set the socket host and port at init time so that it does not have to make a DNS call for every send.

Also update dependencies and clear warnings so that things work smoothly on Ruby 2.3.0.

ferrous26 and others added 2 commits March 26, 2016 21:26
And set the socket host and port at init time so that it does not have
to make a DNS call for every send.
Using an older jeweler depended on a version of nokogiri that would not
build for me; updating fixed that.

I was getting runtime warnings from shoulda and mocha; updating them
and changing the requirement fixed that.
@milgner
Copy link
Contributor

milgner commented Aug 21, 2016

Hi @ferrous26,

support for IPv6 is very welcome! Nonetheless I'm a bit uncomfortable with the rest of the changes as this drops support for quite a number of old Ruby versions and seems to pull in a dependency on ActiveSupport. Also, we should provide a possibility to make the connect call on the socket optional to prevent breaking it for setups that use special DNS setups like round-robin.
If you could rebase it onto the current master branch (which already addresses a number of changes you made here, too), it would be much appreciated.

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants