feat: add FoldingHeading extension #314
Conversation
|
TODO: add docs how to connect FoldingHeading extension |
|
Preview is ready. |
src/i18n/menubar/en.json
Outdated
| @@ -17,6 +17,8 @@ | |||
| "cut": "Cut", | |||
| "emoji": "Emoji", | |||
| "file": "File", | |||
| "folding-heading": "Collapsed section", | |||
| "folding-heading_hint": "The text under the heading can be collapsed or expanded.", | |||
There was a problem hiding this comment.
Do we need a dot at the end?
| @@ -7,5 +7,5 @@ export const YfmHeadingAttr = { | |||
| Level: headingLevelAttr, | |||
| Id: 'id', | |||
| DataLine: 'data-line', | |||
| Folding: 'folding', | |||
| Folding: 'folded', | |||
There was a problem hiding this comment.
It seems unusual that the term "folded" has been used in conjunction with the key Folding. Is this change necessary? Would it be possible to use "folding", to maintain consistency with the rest of the codebase?
There was a problem hiding this comment.
"folded" explains the meaning better. That can be true if heading is folded (section is collapsed). False, if heading is open. And null if it is a common heading.
Field "Folding" remains the same for backward compatibility.
| decorations.push( | ||
| Decoration.node(item.from, item.to, { | ||
| nodeName: 'div', | ||
| class: 'pm-h-folding-label', |
There was a problem hiding this comment.
The name of the class is not clear. Maybe you should not use abbreviations? For example: pm-folding-heading-label
Also do we need to put pm in front of the class name in our code? I thought pm is the prefix that prosemirror puts in its own code.
There was a problem hiding this comment.
Also do we need to put pm in front of the class name in our code? I thought pm is the prefix that prosemirror puts in its own code.
prosemirror uses prefix ProseMirror- for its own classes.
I don't see anything wrong with using the prefix pm- to denote entities that can only be inside the wysiwyg editor.
The separator was inserted in the wrong place |
| TokenType.ContentClose, | ||
| ]; | ||
|
|
||
| export const skipSectionsPlugin: PluginSimple = (md) => { |
| return buildDecosSet(tr.doc); | ||
| } | ||
|
|
||
| if (!tr.docChanged) return prev.map(tr.mapping, tr.doc); |
There was a problem hiding this comment.
lets use one if
for return prev.map(tr.mapping, tr.doc);
There was a problem hiding this comment.
add comment pzl about optimization
No description provided.