NET-1603: Manage DNS NM changes #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek9686
requested changes
Oct 10, 2024
mq/mq.go
Outdated
There was a problem hiding this comment.
remove periodic sync check, instead this can be published when peer update is pushed
There was a problem hiding this comment.
Move to peerUpdate in new commit. please review again.
| @@ -249,3 +250,48 @@ func sendPeers() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func sendDNSSync() error { | |||
There was a problem hiding this comment.
this func should be simplified to all get all entries from the DB and push it to clients
There was a problem hiding this comment.
Removed the cache in new commit. Please help review again.
|
add relevant PR title |
yabinma
changed the title
abhishek9686
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Provide Issue ticket number if applicable/not in title
Provide testing steps
Checklist before requesting a review