Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-602: delete ext clients when ingress node is removed from network #2554

Merged
merged 44 commits into from
Sep 5, 2023
Merged

NET-602: delete ext clients when ingress node is removed from network #2554

merged 44 commits into from
Sep 5, 2023

Conversation

abhishek9686
Copy link
Member

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

abhishek9686 and others added 30 commits August 16, 2023 16:34
@abhishek9686
add superadmin role, apis to create superadmin user
11655df
@abhishek9686
apis to attach and remove user from remote access gateways
f66cd3d
@abhishek9686
add api to list user's remote client has gateway clients
6cd7939
@abhishek9686
remove code related user groups
d4b76fb
@abhishek9686
remove networks and groups from user model
33c0707
@abhishek9686
refactor user CRUD operations
abdd2e4
@abhishek9686
fix network permission test
f53bbd0
@abhishek9686
add superadmin to authorize func
7526ee2
@abhishek9686
remove user network and groups from cli
89fb719
@abhishek9686
api to transfer superadmin role
76ec51e
@abhishek9686
add api to list users on a ingress gw
e544fee
@abhishek9686
restrict user access to resources on server
595911b
@abhishek9686
deny request from remote access client if extclient is already created
b301a1e
@abhishek9686
fix user tests
4cbfb3e
@abhishek9686
fix static checks
ad32f06
@abhishek9686
fix static checks
f3f2cfd
@abhishek9686
add limits to extclient create handler
98e7a98
@abhishek9686
set username to superadmin on if masterkey is used
6ffac8c
@abhishek9686
allow creation of extclients using masterkey
6e7f8c7
@abhishek9686
add migration func to assign superadmin role for existing admin user
ed5d022
@abhishek9686
Merge branch 'develop' into NET-551
93dfd80
@abhishek9686
check for superadmin on migration if users are present
484ce65
@abhishek9686
Merge branch 'NET-551' of https://github.com/gravitl/netmaker into NE…
a2558d8 
…T-551
@abhishek9686
allowe masterkey to extcleint apis
72ba473
@abhishek9686
check ownerid
41d6ca9
@abhishek9686
format error, on jwt token verification failure return unauthorized r…
299d086 
…ather than forbidden
@abhishek9686
user update fix
8136d03
@abhishek9686
move user remote functionality to ee
be71536
@abhishek9686
fix update user api
2f78fc8
@abhishek9686
security patch
06088b9
mattkasun
mattkasun suggested changes Sep 5, 2023
View reviewed changes
controllers/hosts.go Outdated Show resolved Hide resolved
theguy951357
theguy951357 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and passed by rohit

@abhishek9686 abhishek9686 merged commit 166e619 into develop Sep 5, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkasun mattkasun mattkasun approved these changes

@theguy951357 theguy951357 theguy951357 approved these changes

@Aceix Aceix Aceix approved these changes

@gabrielseibel1 gabrielseibel1 Awaiting requested review from gabrielseibel1

@pwilson77 pwilson77 Awaiting requested review from pwilson77

@afeiszli afeiszli Awaiting requested review from afeiszli

@uGiFarukh uGiFarukh Awaiting requested review from uGiFarukh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishek9686 @Aceix @theguy951357 @mattkasun