[NET-546] Move ee code to ee package, unify ee status and terminology #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielseibel1
requested review from
Aceix,
theguy951357,
afeiszli,
abhishek9686,
mattkasun and
uGiFarukh
abhishek9686
requested changes
Aug 24, 2023
… Notes: - Changes image tags - Changes build tags - Changes package names - Doesn't change links to docs that mention "ee" - Doesn't change parameters sent to PostHog that mention "ee"
gabrielseibel1
changed the title
abhishek9686
approved these changes
Aug 25, 2023
mattkasun
approved these changes
Aug 25, 2023
abhishek9686
requested changes
Aug 28, 2023
There was a problem hiding this comment.
@gabrielseibel1 can you revert changes of ee -> pro for docker images and workflow, tags
Aceix
requested changes
Aug 28, 2023
Aceix
approved these changes
Aug 28, 2023
mattkasun
approved these changes
Aug 28, 2023
abhishek9686
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Moved all pieces of code that where specific to EE/Pro to correct directory.
Used variable functions that are filled in with pro code on pro initialization.
Main areas affected are metrics, relays, and ext. client acls.
Lot of the refactoring was done with automation/IDE tools, and go vet, staticcheck and go test pass, but nonetheless we should manually test this thoroughly since the diff is huge... lots of moving this around but logic should be the same.
Consolidated naming for paid/professional/enterprise version as "pro". Notes:
Provide testing steps
Test that pro features mentioned above are working and not available on community