set endpoint and port when registering #2505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aceix
requested review from
theguy951357,
gabrielseibel1,
afeiszli,
abhishek9686,
mattkasun and
uGiFarukh
Aceix
changed the title
abhishek9686
requested changes
Aug 10, 2023
| @@ -140,7 +142,22 @@ func SessionHandler(conn *websocket.Conn) { | |||
| return | |||
| } | |||
| } | |||
| logic.CheckHostPorts(&result.Host) | |||
| if slices.Contains(registerMessage.CustomParams, models.HostRegisterCustomParamListenPort) { | |||
There was a problem hiding this comment.
this fields are already on host model, not required to extend the req to have custom params
There was a problem hiding this comment.
I don't think these changes are required, all the changes should be only on client side for user to set IP and Port for a host
There was a problem hiding this comment.
Mainly had to do this for the port check. Otherwise logic.CheckHostPorts(&result.Host) will automatically assign any free port even when user specifies one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
check NET-497
Provide Issue ticket number if applicable/not in title
Provide testing steps
Checklist before requesting a review